Change api provider #12200
Merged
Change api provider #12200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…angeprovider method.
shnrndk
force-pushed
the
changeApiProvider3
branch
from
f0b0fb2 to
40c4078
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #12200 +/- ##
=============================================
+ Coverage 20.77% 41.66% +20.88%
- Complexity 0 3203 +3203
=============================================
Files 1205 1824 +619
Lines 102811 134578 +31767
Branches 14407 19441 +5034
=============================================
+ Hits 21363 56068 +34705
+ Misses 78648 71771 -6877
- Partials 2800 6739 +3939
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
prasa7
reviewed
Jan 9, 2024
...admin.v1/src/main/java/org/wso2/carbon/apimgt/rest/api/admin/v1/impl/ApisApiServiceImpl.java
Show resolved
Hide resolved
prasa7
previously approved these changes
Feb 2, 2024
Arshardh
reviewed
Feb 7, 2024
...carbon.apimgt.persistence/src/main/java/org/wso2/carbon/apimgt/persistence/APIConstants.java
Outdated
Show resolved
Hide resolved
shnrndk
force-pushed
the
changeApiProvider3
branch
from
7e28fba to
9d96651
Compare
Arshardh
approved these changes
Feb 7, 2024
| @@ -50,7 +50,10 @@ public class SearchApiServiceImpl implements SearchApiService { | |||
| public Response search(Integer limit, Integer offset, String query, String ifNoneMatch, | |||
| MessageContext messageContext) throws APIManagementException { | |||
| SearchResultListDTO resultListDTO = new SearchResultListDTO(); | |||
|
|
|||
| if (!query.equals(RestApiConstants.PIZZASHACK_SEARCH_QUERY) && (query.startsWith("name:") | | |||
There was a problem hiding this comment.
Let's create a git issue to track a better fix for this as we discussed
There was a problem hiding this comment.
Created the git issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: wso2/api-manager#398