Admin portal API scopes related fixs #12182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chamilaadhi
force-pushed
the
admin_portal
branch
from
c9b6a2f to
64ee390
Compare
| JsonObject jsonObject = jsonParser.parse(systemConfig).getAsJsonObject(); | ||
|
|
||
| // Get the existing rest api scopes | ||
| if (jsonObject.has("RESTAPIScopes")) { |
There was a problem hiding this comment.
We might be able to add some of these strings to constants. Ex:RESTAPIScopes
tharikaGitHub
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix includes
apim:tier_manageandapim:tier_viewroles are already used in publisher rest api. Fixing Missing scopes for admin portal in Scope Assignments section api-manager#2255