Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Web Socket Invocation Error with Tracing Enabled #11936

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

BLasan
Copy link
Contributor

@BLasan BLasan commented Mar 21, 2023

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch coverage: 15.55% and project coverage change: -0.60 ⚠️

Comparison is base (5c49840) 38.66% compared to head (d2dc4b2) 38.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11936      +/-   ##
==========================================
- Coverage   38.66%   38.06%   -0.60%     
==========================================
  Files        1778     1778              
  Lines      127466   127475       +9     
  Branches    18213    18220       +7     
==========================================
- Hits        49288    48527     -761     
- Misses      71925    72751     +826     
+ Partials     6253     6197      -56     
Flag Coverage Δ
integration_tests 30.49% <15.55%> (-0.72%) ⬇️
unit_tests 20.57% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...y/handlers/common/APIMgtLatencySynapseHandler.java 10.86% <0.00%> (-0.90%) ⬇️
...wso2/carbon/apimgt/gateway/utils/GatewayUtils.java 41.93% <0.00%> (ø)
...2/carbon/apimgt/keymgt/SubscriptionDataHolder.java 85.71% <77.77%> (-2.75%) ⬇️

... and 71 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

}
return subscriptionDataStore;
return null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we check if there are any possible null pointers that can occur as a result of sending null.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants