Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Prometheus functionality in adapter and common controller #2135

Merged
merged 5 commits into from
Mar 25, 2024

Conversation

sgayangi
Copy link
Contributor

@sgayangi sgayangi commented Mar 15, 2024

This PR contains the following changes.

  1. The operator present in both the adapter and common controller inherently have a metrics endpoint available by default at port 8080. Instead of spinning up an additional Prometheus server, the code was refactored to utilise the existing metrics endpoint to expose Prometheus metrics.
  2. Additionally, the existing method of providing the metrics bind address needed to be refactored due to the gateway API dependency update from PR Upgrade K8s gateway api to v1.0.0 #2121.
  3. This PR fixes Update Prometheus functionality in adapter and common controller #2134

@sgayangi sgayangi added the trigger-action When this includes apk actions getting trigger for pr label Mar 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.95%. Comparing base (a47add3) to head (64893bb).
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2135   +/-   ##
=======================================
  Coverage   27.95%   27.95%           
=======================================
  Files         124      124           
  Lines       14583    14583           
  Branches     2672     2672           
=======================================
  Hits         4076     4076           
  Misses      10376    10376           
  Partials      131      131           
Flag Coverage Δ
adapter 27.63% <ø> (ø)
common-controller 4.07% <ø> (ø)
config-deployer-service 26.03% <ø> (ø)
idp-domain-service 80.21% <ø> (ø)
router ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sgayangi sgayangi requested a review from pubudu538 March 15, 2024 06:28
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Mar 15, 2024
@sgayangi sgayangi force-pushed the prom-operator branch 2 times, most recently from ea6115e to bc34cc1 Compare March 15, 2024 07:58
@sgayangi sgayangi added the trigger-action When this includes apk actions getting trigger for pr label Mar 15, 2024
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Mar 15, 2024
@sgayangi sgayangi added the trigger-action When this includes apk actions getting trigger for pr label Mar 18, 2024
pubudu538
pubudu538 previously approved these changes Mar 18, 2024
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Mar 18, 2024
@sgayangi sgayangi added the trigger-action When this includes apk actions getting trigger for pr label Mar 18, 2024
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Mar 18, 2024
@sgayangi sgayangi added the trigger-action When this includes apk actions getting trigger for pr label Mar 18, 2024
@Krishanx92 Krishanx92 merged commit 5097646 into wso2:main Mar 25, 2024
11 of 12 checks passed
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Mar 25, 2024
@sgayangi sgayangi mentioned this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Prometheus functionality in adapter and common controller
5 participants