Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues in the version of v1alpha1 of API CR #2130

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Conversation

pubudu538
Copy link
Contributor

@pubudu538 pubudu538 commented Mar 13, 2024

Purpose

  1. Add go build to common-go-libs
  2. Update helm chart to enable conversion webhook.

It looks like validation web hooks are deploying with the API CRs that we deploy. The APIs are our system APIs. Hence validations are not happening. We can't event validate the APIs as we need to make sure our common controller up and running before deploying these APIs.

In this case, I have added a helm hook as post-install to delay the installation of the API CRs in order to allow the installation of the API CR. With helm v3, we cant template crds in a native way. A weight has been added to the validation webhooks to delay the installation and to make those are installed after API CRs. As we can't control the common controller availability, we cant validate these APIs.

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email [email protected] to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to [email protected] and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

@pubudu538 pubudu538 added the trigger-action When this includes apk actions getting trigger for pr label Mar 13, 2024
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Mar 21, 2024
@pubudu538 pubudu538 changed the title [Draft]Fix issues in the version of v1alpha1 of API CR Fix issues in the version of v1alpha1 of API CR Mar 21, 2024
@pubudu538 pubudu538 added the trigger-action When this includes apk actions getting trigger for pr label Mar 21, 2024
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Mar 21, 2024
@pubudu538 pubudu538 added the trigger-action When this includes apk actions getting trigger for pr label Mar 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.93%. Comparing base (675cfb5) to head (a0e6f15).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2130   +/-   ##
=======================================
  Coverage   27.93%   27.93%           
=======================================
  Files         124      124           
  Lines       14597    14597           
  Branches     2681     2681           
=======================================
  Hits         4078     4078           
  Misses      10388    10388           
  Partials      131      131           
Flag Coverage Δ
adapter 27.63% <ø> (ø)
common-controller 4.07% <ø> (ø)
config-deployer-service 25.99% <ø> (ø)
idp-domain-service 80.21% <ø> (ø)
router ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pubudu538 pubudu538 merged commit dedaf2b into wso2:main Mar 25, 2024
23 of 24 checks passed
@github-actions github-actions bot removed the trigger-action When this includes apk actions getting trigger for pr label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants