-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DB support for controlplane data in dataplane side #2020
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2020 +/- ##
==========================================
- Coverage 28.00% 27.95% -0.06%
==========================================
Files 124 124
Lines 14553 14582 +29
Branches 2672 2672
==========================================
Hits 4076 4076
- Misses 10346 10375 +29
Partials 131 131
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -30,6 +31,11 @@ func main() { | |||
logger.Info("Starting the Web server") | |||
go web.StartWebServer() | |||
go server.StartInternalServer() | |||
if conf.CommonController.Database.Enabled { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be nil? CommonController.Database
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it will be handled by default configs
7c9fa92
to
5f5f99d
Compare
03a8fd1
to
52a980e
Compare
Purpose
Fixes #2019
Goals
Approach
User stories
Release note
Documentation
Training
Certification
Marketing
Automation tests
Security checks
Samples
Related PRs
Migrations (if applicable)
Test environment
Learning