Add http, https and multiple port support #1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tharsanan1
force-pushed
the
support-multiple-ports-and-protocol
branch
from
d32b54f to
c4e65bc
Compare
|
Locally tested |
helm-charts/templates/data-plane/gateway-components/adapter/gateway.yaml
Outdated
Show resolved
Hide resolved
| return false | ||
| }) | ||
| if alreadyExistsInRouteConfigList { | ||
| logger.LoggerAPKOperator.Debugf("Route already exists. %+v", routesConfig.Name) |
There was a problem hiding this comment.
Can this happen? I didn't get how there could be duplicate routes at this level.
There was a problem hiding this comment.
Without this check I faced only a part of routes added to the speific route config. Thats why i added this check
Tharsanan1
force-pushed
the
support-multiple-ports-and-protocol
branch
from
7bebca2 to
b81de35
Compare
Tharsanan1
added
the
trigger-action
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1881 +/- ##
==========================================
+ Coverage 4.63% 28.08% +23.44%
==========================================
Files 5 123 +118
Lines 626 14009 +13383
Branches 0 2567 +2567
==========================================
+ Hits 29 3934 +3905
- Misses 597 9940 +9343
- Partials 0 135 +135
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
github-actions
bot
removed
the
trigger-action
Tharsanan1
added
the
trigger-action
github-actions
bot
removed
the
trigger-action
Tharsanan1
added
trigger-action
Tharsanan1
added
trigger-action
AmaliMatharaarachchi
approved these changes
Jan 4, 2024
github-actions
bot
removed
the
trigger-action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose