Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IdP functionality for visibility and access control support #1837

Closed
wants to merge 6 commits into from

Conversation

sgayangi
Copy link
Contributor

  • Related issue: API Visibility Support #1780
  • Adds the support for groups claim in the non-production IdP
  • Adds cucumber test for visibility support

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (efb1c39) 25.68% compared to head (9b9d168) 67.06%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1837       +/-   ##
===========================================
+ Coverage   25.68%   67.06%   +41.37%     
===========================================
  Files         134       19      -115     
  Lines       15100     1746    -13354     
  Branches     2453      987     -1466     
===========================================
- Hits         3879     1171     -2708     
+ Misses      11090      575    -10515     
+ Partials      131        0      -131     
Flag Coverage Δ
adapter ?
backoffice-domain-service 60.77% <ø> (?)
common-controller ?
config-deployer-service ?
idp-domain-service 80.28% <ø> (+0.10%) ⬆️
router ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 137 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sgayangi
Copy link
Contributor Author

Closed since backoffice and devportal functionalities were put on hold temporarily, will reopen when needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants