Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change package of common-controller crd #1810

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

tharindu1st
Copy link
Contributor

change package of common-controller crd

Krishanx92
Krishanx92 previously approved these changes Oct 10, 2023
@ashera96
Copy link
Contributor

Shall we rename api/dp to apis/dp just like we have in adapter side?

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (fa8ca1a) 25.98% compared to head (31b07e0) 1.11%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #1810       +/-   ##
==========================================
- Coverage   25.98%   1.11%   -24.87%     
==========================================
  Files         250      15      -235     
  Lines       29544    1430    -28114     
  Branches     4894       0     -4894     
==========================================
- Hits         7678      16     -7662     
+ Misses      21604    1414    -20190     
+ Partials      262       0      -262     
Flag Coverage Δ
adapter ?
common-controller 1.11% <ø> (ø)
config-deployer-service ?
idp-domain-service ?
router ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 263 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tharindu1st tharindu1st merged commit 2548d19 into wso2:main Oct 10, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants