Template hostnames #1761
Merged
Template hostnames #1761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1761 +/- ##
==========================================
Coverage 25.56% 25.56%
==========================================
Files 262 131 -131
Lines 30326 15163 -15163
Branches 5122 2561 -2561
==========================================
- Hits 7752 3876 -3876
+ Misses 22312 11156 -11156
+ Partials 262 131 -131
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -24,7 +24,7 @@ metadata: | |||
| api-version: "1.0.0" | |||
| spec: | |||
| hostnames: | |||
| - "api.am.wso2.com" | |||
| - "{{ .Values.wso2.apk.listener.hostname | default "api.am.wso2.com"}}" | |||
There was a problem hiding this comment.
let's add all new helm variables to values.template file
There was a problem hiding this comment.
It's already added template file and readme
tharindu1st
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose