Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp JWT validation #1744

Closed
wants to merge 6 commits into from

Conversation

AmaliMatharaarachchi
Copy link
Contributor

@AmaliMatharaarachchi AmaliMatharaarachchi commented Sep 12, 2023

Purpose

Fixes #1747

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email [email protected] to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to [email protected] and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

@AmaliMatharaarachchi AmaliMatharaarachchi marked this pull request as draft September 12, 2023 16:55
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0bfa91d) 25.98% compared to head (b66e027) 25.98%.
Report is 31 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1744      +/-   ##
==========================================
  Coverage   25.98%   25.98%              
==========================================
  Files         250      125     -125     
  Lines       29544    14772   -14772     
  Branches     4894     2447    -2447     
==========================================
- Hits         7678     3839    -3839     
+ Misses      21604    10802   -10802     
+ Partials      262      131     -131     
Flag Coverage Δ
adapter 25.54% <ø> (ø)
common-controller 1.11% <ø> (ø)
config-deployer-service 28.34% <ø> (ø)
idp-domain-service 80.10% <ø> (ø)
router ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 125 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AmaliMatharaarachchi AmaliMatharaarachchi marked this pull request as ready for review September 13, 2023 09:36
@AmaliMatharaarachchi AmaliMatharaarachchi changed the base branch from main to feature/revamp-jwt September 13, 2023 09:40
@AmaliMatharaarachchi AmaliMatharaarachchi changed the base branch from feature/revamp-jwt to main September 15, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor JWT validation
2 participants