Delete unused organization related entries from internal map #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -846,6 +846,21 @@ func RemoveAPICacheForEnv(adapterInternalAPI model.AdapterInternalAPI, envType s | |||
| } | |||
| } | |||
|
|
|||
| // RemoveAPIFromOrgAPIMap removes api from orgAPI map | |||
| func RemoveAPIFromOrgAPIMap(adapterInternalAPI model.AdapterInternalAPI, orgId string) { | |||
There was a problem hiding this comment.
you just use the uuid from the adapterInternalAPI right? why not directly send it here?
There was a problem hiding this comment.
Modified the code
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1695 +/- ##
==========================================
- Coverage 25.48% 25.46% -0.03%
==========================================
Files 262 131 -131
Lines 30288 15153 -15135
Branches 5116 2558 -2558
==========================================
- Hits 7718 3858 -3860
+ Misses 22308 11164 -11144
+ Partials 262 131 -131
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tharindu1st
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose