Update routes when production or sandbox endpoints changed #1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1686 +/- ##
==========================================
- Coverage 25.63% 25.48% -0.15%
==========================================
Files 40 131 +91
Lines 8633 15142 +6509
Branches 0 2557 +2557
==========================================
+ Hits 2213 3859 +1646
- Misses 6289 11152 +4863
Partials 131 131
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -86,6 +86,10 @@ func (ods *OperatorDataStore) processAPIState(apiNamespacedName types.Namespaced | |||
| } | |||
| } else { | |||
| cachedAPI.ProdHTTPRoute = nil | |||
| if cachedAPI.ProdHTTPRoute != nil { | |||
There was a problem hiding this comment.
this line always would be false due to above line
There was a problem hiding this comment.
fixed the logic.
AmaliMatharaarachchi
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose