Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Provide Sequence as a Backend for APIs #743

Merged
merged 12 commits into from
Sep 27, 2024

Conversation

BLasan
Copy link
Contributor

@BLasan BLasan commented Sep 16, 2024

Provide a separate Endpoint option for REST APIs to define a sequence as its backend. This addresses the following use-cases.

  1. Add new Sequence for Production and Sandbox key types.
  2. Delete a sequence
  3. Download a sequence

UI will now look as follows for the REST APIs.
Screenshot 2024-09-25 at 01 04 55
Screenshot 2024-09-25 at 01 06 41

Related Issues

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

SavinduDimal pushed a commit to SavinduDimal/apim-apps that referenced this pull request Sep 26, 2024
SavinduDimal pushed a commit to SavinduDimal/apim-apps that referenced this pull request Sep 26, 2024
@@ -0,0 +1,621 @@
/* eslint-disable */
/*
* Copyright (c) 2022, WSO2 Inc. (http://www.wso2.org) All Rights Reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change this to the new license text



/**
* Method to upload the certificate content by calling the rest api.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we fix add the correct method comments

@Krishanx92
Copy link
Contributor

Can you attached new UI design

setIsValidSequenceBackend(false);
restAPI.getSequenceBackends(api.id)
.then((result) => {
console.log(result);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove console log

};

const downloadCustomBackend = (keyType) => {
console.log("Downloading");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove and check all other places

productionBackendList.push({"sequenceName": customBackend.name, "content": customBackend.content});
}
restAPI.uploadCustomBackend(customBackend.content, uploadCustomBackendOpen.keyType, api.id).then((resp) => {
console.log('Custom backend uploaded successfully' + resp);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need messge box not console log

@@ -298,6 +314,9 @@ function EndpointOverview(props) {
{ key: 'awslambda', value: 'AWS Lambda' },
];
}
if(apiObject.gatewayType !== 'wso2/apk' && type === 'HTTP' ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting

@BLasan
Copy link
Contributor Author

BLasan commented Sep 26, 2024

Can you attached new UI design

Attached in the description. #743 (comment)

Krishanx92
Krishanx92 previously approved these changes Sep 26, 2024
@BLasan BLasan force-pushed the sequence-as-backend branch from 645d3d2 to 12fe461 Compare September 27, 2024 05:36
Krishanx92
Krishanx92 previously approved these changes Sep 27, 2024
Copy link

sonarcloud bot commented Sep 27, 2024

@RakhithaRR RakhithaRR merged commit dc12f27 into wso2:main Sep 27, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants