Skip to content

csm-portal backend: time-card create + update passthrough - #990

Merged
Rashmika998 merged 2 commits into
wso2-open-operations:v2from
rksk:time-card-write-backend
Jun 30, 2026
Merged

Rashmika998 merged 2 commits into
wso2-open-operations:v2from
rksk:time-card-write-backend

Conversation

@rksk

@rksk rksk commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

What

Adds BFF passthrough endpoints for time-card writes, alongside the existing POST /time-cards/search:

  • POST /time-cards — create.
  • PATCH /time-cards/{id} — update. The body carries either editable fields, or a state transition: {"state":"approved"} or {"state":"rejected","leadComment":"..."}.

Both are thin auth-checked passthroughs to the entity service (raw JSON body forwarded; UUID path param validated for the PATCH). Authorization is enforced downstream.

Layers

Entity client methods, handler interface + handlers, routes, openapi.yaml (paths + schemas), test mock, and handler tests. go build, go test clean.

Depends on

The entity-service time-card write endpoints (#989) — this BFF forwards to them.

Add POST /time-cards (create) and PATCH /time-cards/{id} (update) BFF passthroughs
to the entity service, alongside the existing POST /time-cards/search. The PATCH
body carries either editable fields or a state transition ({"state":"approved"}
or {"state":"rejected","leadComment":"..."}); the entity service enforces
authorization. Entity client methods, handler interface + handlers, routes,
openapi paths/schemas, mock, and handler tests included.
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@rksk, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 58 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c9ecf51b-c1d3-4945-b407-096cf7e2a5c0

📥 Commits

Reviewing files that changed from the base of the PR and between 193bbc1 and cee7476.

📒 Files selected for processing (6)
  • apps/csm-portal/backend/cmd/server/main.go
  • apps/csm-portal/backend/internal/entity/entity.go
  • apps/csm-portal/backend/internal/handler/helpers_test.go
  • apps/csm-portal/backend/internal/handler/time_cards.go
  • apps/csm-portal/backend/internal/handler/time_cards_test.go
  • apps/csm-portal/backend/openapi.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Parity with the entity-service contract (wso2-open-operations#989): reject an empty/no-op PATCH body
in the spec; the entity service enforces it and this BFF passes the body through.
@Rashmika998
Rashmika998 merged commit b33d158 into wso2-open-operations:v2 Jun 30, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants