[Customer Entity] Extend service-requests search response and add email to assignedEngineer - #905
Conversation
…ice-requests search, and case details responses
|
Warning Review limit reached
More reviews will be available in 21 minutes and 7 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughAdds an optional ChangesAssignedEngineerRef email and conversation removal
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
entity-service/openapi.yaml (1)
1410-1412: 🧹 Nitpick | 🔵 Trivial | ⚡ Quick winAdd
format: emailtoAssignedEngineerRef.emailfor schema consistency.This keeps generated-client validation consistent with other email fields in this spec.
Suggested diff
AssignedEngineerRef: type: object nullable: true properties: id: type: string name: type: string email: type: string + format: email nullable: true🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@entity-service/openapi.yaml` around lines 1410 - 1412, The AssignedEngineerRef.email field in the OpenAPI schema is missing the format specification that other email fields in the spec have. Add the format property with value "email" to the email field definition (located in the type: string, nullable: true block for AssignedEngineerRef.email) to ensure consistent validation behavior across generated clients and align with other email field definitions in the specification.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@entity-service/openapi.yaml`:
- Around line 1899-1909: The `conversation` field has been removed from the
`ServiceRequestView` schema in `entity-service/openapi.yaml`, but downstream
consumers like the `customer-portal` backend still define `conversation` as a
required field in their `Case` schema. Before releasing this breaking change,
identify all downstream services that consume `ServiceRequestView` responses and
update their schemas to remove or make the `conversation` field
optional/nullable to match the upstream changes. Verify that consuming services
have been deployed with these schema updates to handle responses without the
`conversation` field.
---
Nitpick comments:
In `@entity-service/openapi.yaml`:
- Around line 1410-1412: The AssignedEngineerRef.email field in the OpenAPI
schema is missing the format specification that other email fields in the spec
have. Add the format property with value "email" to the email field definition
(located in the type: string, nullable: true block for
AssignedEngineerRef.email) to ensure consistent validation behavior across
generated clients and align with other email field definitions in the
specification.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 73030772-1b53-4775-a774-d2f0aaed8897
📒 Files selected for processing (3)
entity-service/internal/domain/entity.goentity-service/internal/service/sn_case_service.goentity-service/openapi.yaml
…ity-service PR wso2-open-operations#905 - Add email (nullable) to AssignedEngineerRef schema - Change ServiceRequestView.assignedEngineer ref from EntityRef to AssignedEngineerRef - Remove conversation field from ServiceRequestView (removed upstream) - Rename ServiceRequestSearchResponse.cases array key to serviceRequests Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ity-service PR #905 - Add email (nullable) to AssignedEngineerRef schema - Change ServiceRequestView.assignedEngineer ref from EntityRef to AssignedEngineerRef - Remove conversation field from ServiceRequestView (dropped upstream) - Rename ServiceRequestSearchResponse.cases array key to serviceRequests Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ema-updates [CSM Portal][BE] fix(openapi): align service-requests schema with entity-service PR #905
Summary
conversationfield fromPOST /service-requests/searchresponseemailfield toassignedEngineerinPOST /cases/search,POST /service-requests/search, andGET /cases/{id}responsesSummary by CodeRabbit