Skip to content

[Customer portal][Be] Remove unused fields and update openapi.yaml - #485

Merged
cloby99 merged 1 commit into
wso2-open-operations:mainfrom
Rashmika998:main
Apr 10, 2026
Merged

cloby99 merged 1 commit into
wso2-open-operations:mainfrom
Rashmika998:main

Conversation

@Rashmika998

@Rashmika998 Rashmika998 commented Apr 10, 2026 •

Copy link
Copy Markdown
Contributor

Description

  • Remove unused fields and update openapi.yaml

Summary by CodeRabbit

  • New Features

    • Added support for specifying preferred duration when updating call requests.
  • Refactor

    • Removed instance field from data schema.
  • Documentation

    • Clarified product classification descriptions.

@coderabbitai

coderabbitai Bot commented Apr 10, 2026 •

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

The pull request removes the instance field from the Instance public record type definition and updates the OpenAPI schema by adding an optional durationInMinutes field to CallRequestUpdatePayload while correcting a description string in the Product schema.

Changes

Cohort / File(s) Summary
Type Definitions
apps/customer-portal/backend/modules/types/types.bal
Removed instance field (string) from the Instance public record type.
OpenAPI Schema
apps/customer-portal/backend/openapi.yaml
Added optional durationInMinutes integer field to CallRequestUpdatePayload schema; updated Product.class property description from product_model to Product Model.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • cloby99

Poem

🐰 A field hops away into the past,
While durationInMinutes arrives at last!
The schema grows stronger with each new note,
As types and specs dance in their coat.
✨ Changes spring forth—hooray, hooray! 🌿

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is severely incomplete, containing only a brief statement without addressing most required template sections. Complete the PR description by adding Purpose, Goals, Approach, and other required sections from the template, including issue references, test details, and documentation links.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main changes: removing unused fields and updating the OpenAPI specification.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@apps/customer-portal/backend/openapi.yaml`:
- Around line 2843-2846: Update the OpenAPI schema for
CallRequestUpdatePayload.durationInMinutes to enforce the same lower bound as
server validation by adding "minimum: 1" (keep "format: int64"); ensure the
schema field named durationInMinutes under CallRequestUpdatePayload reflects
this change and verify the server-side check in modules/entity/utils.bal that
uses stateKey == 2 still matches the contract.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 442e8182-b69b-428c-a3fb-d5f9d1fcc604

📥 Commits

Reviewing files that changed from the base of the PR and between e8367ff and 5758ff5.

📒 Files selected for processing (2)
  • apps/customer-portal/backend/modules/types/types.bal
  • apps/customer-portal/backend/openapi.yaml
💤 Files with no reviewable changes (1)
  • apps/customer-portal/backend/modules/types/types.bal

Comment thread apps/customer-portal/backend/openapi.yaml
@cloby99
cloby99 merged commit 4126b7c into wso2-open-operations:main Apr 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants