[Customer Portal[BE] Enhance change request response and include description in deployed product create/update payloads - #279
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughAdds optional metadata fields across customer-portal backend types: a Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/customer-portal/backend/modules/entity/utils.bal`:
- Around line 239-240: The validation message returned when active is true (the
string currently mentioning only "cores or tps" near the active check) must be
updated to include "description" as well; locate the conditional that returns
"Invalid value for active field. When updating cores or tps, active field should
be set to false." (the active validation branch) and change the message to
mention "cores, tps, or description" so it reflects the new supported field in
this validation path.
ℹ️ Review info
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
apps/customer-portal/backend/modules/entity/types.balapps/customer-portal/backend/modules/entity/utils.balapps/customer-portal/backend/modules/types/types.balapps/customer-portal/backend/service.balapps/customer-portal/backend/utils.bal
35688a9
into
wso2-open-operations:customer-portal-milestone-1
Description
This PR enhances the change request response structure and updates the deployed product create and update payloads to include a
descriptionfield.Changes
1️⃣ Change Request Response Enhancement
Reason:
The existing response did not include sufficient contextual information required by the UI and reporting flows.
2️⃣ Include Description in Deployed Product Create & Update
descriptionfield to:Reason:
Including a
descriptionfield enables:Impact
Testing
Related PRs
Summary by CodeRabbit