[CSM][BE][Web] Skip SCIM external-account lookup for wso2.com emails - #1444
Merged
shayanmalinda merged 1 commit intoAug 12, 2026
Merged
shayanmalinda merged 1 commit into
shayanmalinda merged 1 commit into
Conversation
A ServiceNow project-contact row can carry a wso2.com email under a customer-facing userType/role (e.g. snc_external) despite belonging to a WSO2 employee. That account can never exist in the SCIM "external" org -- it's reserved for WSO2 staff -- so the lookup (and the resulting Overview field / locked alert on UserProfilePage) is now skipped whenever the email's domain is wso2.com, regardless of userType/role. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe backend now skips SCIM external-account enrichment for ChangesWSO2 external-account handling
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
shayanmalinda
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1421. A ServiceNow project-contact row can carry a wso2.com email under a customer-facing
userType/role (e.g.snc_external) despite belonging to a WSO2 employee. That account can never exist in the SCIM "external" org — it's reserved for WSO2 staff — so both the SCIM lookup and the resulting UI (the Overview card's "External account" field and the locked-account alert onUserProfilePage) are now skipped whenever the email's domain iswso2.com, regardless ofuserType/role.Gated on email domain rather than the specific
snc_externalrole string since it's the necessary-and-sufficient condition (a wso2.com account can never appear in that SCIM org under any role) and more robust to role-string variants.Test plan
go build ./... && go vet ./... && go test ./...— all passgosec -fmt=text ./...— 0 issues in changed files (2 pre-existing, unrelated findings remain ininternal/dashboard/registry.go)tsc -b— cleaneslinton changed files — cleanvitest run—UserProfilePage.test.tsx(19 tests, incl. a new one for this fix) andCsmSideBar.test.tsx(3 tests) all pass🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
Tests