Conversation
Root cause of Recents staying empty across every previous fix attempt: this IdP issues a fresh `sub` value per session, not a stable one per account — confirmed by inspecting localStorage in a real browser, where the cached "last known user" pointer and the bucket actually holding data had two different sub-looking values for the same person. No amount of timing/caching fixes on top of `sub` could work, since the identifier itself changes every sign-in. Switch to the ID token's `userid` claim (added to IdTokenClaims), which this IdP issues as a stable per-account identifier. Existing recents recorded under the old sub-keyed buckets are orphaned (harmless dead data) — Recents starts fresh under the userid-keyed bucket, but is now reliable across tabs/reloads/days going forward. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 19 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Follow-up to #1174 (already merged), which scoped the QuickNav palette's client-only "recent views"
localStoragecache to the signed-in user, to prevent one user's recent/pinned cases from leaking to the next person signing in on a shared machine.After merge, testing showed Recents still went missing in a new tab despite the correct-looking data sitting in
localStorage. Root cause: this IdP issues a freshsubvalue per session, not a stable one per account — confirmed by inspectinglocalStoragein a real browser, where the cached "last known user" pointer and the bucket actually holding the data had two differentsub-looking values for the same person. No timing/caching fix on top ofsubcould work, since the identifier itself changes every sign-in.useridtoIdTokenClaims(src/utils/userClaims.ts) — this IdP issues it as a stable per-account identifier, unlikesub.useRecentViews.ts's storage-key scoping fromsubtouserid.Existing recents recorded under the old
sub-keyed buckets are orphaned (harmless dead data, never read again) — Recents starts fresh under theuserid-keyed bucket, but is now reliable across tabs/reloads/days going forward.Test plan
tsc -b --noEmitpasseseslintpassesvitest runpasses (useRecentViews.test.ts)vite buildsucceedsmain(post-[CSM][Web] Align QuickNav search palette with customer-portal's style #1174 merge)🤖 Generated with Claude Code