Conversation
📝 WalkthroughWalkthroughThis PR makes two independent UI adjustments: the "Change state" button in CaseActionBar now uses a contained variant with primary color, and the field-change display format in CaseActivitiesFeed changes from "new was old" struck-through phrasing to an "old → new" arrow format, with matching test updates. ChangesUI Tweaks
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Added two more fixes in the latest commit: 1. Loading overlay — full-screen cover 2. State-change display — arrow format Comment added by Claude on behalf of @Rashmika998. |
… new - CaseActionBar: "Change state" button switches from outlined to contained primary so the primary action reads as primary at a glance in the action bar - CaseActivitiesFeed: FieldChangeLine now renders "Old → New" instead of "New was ~~Old~~" — the arrow reads left-to-right as a transition, matching how users think about state changes Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
e218a19 to
837e782
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (1)
apps/csm-portal/webapp/src/features/csm-cases/components/CaseActivitiesFeed.tsx (1)
106-119: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winConsider a screen-reader-friendly transition cue.
The old→new relationship is now conveyed purely by the "→" glyph and color styling. Screen readers may announce this ambiguously (e.g., skip the arrow or read it as "right arrow") without a clear "changed from ... to ..." semantic, unlike the previous "was" phrasing which was more explicit for assistive tech.
Consider adding a visually-hidden label (e.g.,
<Box component="span" sx={visuallyHidden}>changed from</Box>) around the arrow, or anaria-labelon the line summarizing the transition.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/csm-portal/webapp/src/features/csm-cases/components/CaseActivitiesFeed.tsx` around lines 106 - 119, The transition text in CaseActivitiesFeed’s change rendering is only communicated via the arrow glyph and styling, which is not screen-reader friendly. Update the rendering around the field value swap in the relevant JSX to expose an explicit “changed from … to …” cue for assistive tech, either by adding a visually hidden label near the arrow or by applying an accessible aria-label to the container/transition text while keeping the current visual layout.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@apps/csm-portal/webapp/src/features/csm-cases/components/CaseActivitiesFeed.tsx`:
- Around line 106-119: The transition text in CaseActivitiesFeed’s change
rendering is only communicated via the arrow glyph and styling, which is not
screen-reader friendly. Update the rendering around the field value swap in the
relevant JSX to expose an explicit “changed from … to …” cue for assistive tech,
either by adding a visually hidden label near the arrow or by applying an
accessible aria-label to the container/transition text while keeping the current
visual layout.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: fc1deaae-f033-4d9d-bdf6-a6fbc2c1dbde
📒 Files selected for processing (3)
apps/csm-portal/webapp/src/features/csm-cases/components/CaseActionBar.tsxapps/csm-portal/webapp/src/features/csm-cases/components/CaseActivitiesFeed.test.tsxapps/csm-portal/webapp/src/features/csm-cases/components/CaseActivitiesFeed.tsx
✅ Files skipped from review due to trivial changes (1)
- apps/csm-portal/webapp/src/features/csm-cases/components/CaseActionBar.tsx
Summary
LinearProgressbehindhasInitializedso it only appears after auth has settled. Previously both the top-bar loader and the centered auth loader rendered simultaneously during the initial page load, causing two overlapping orange bars.variant="outlined"tovariant="contained" color="primary"so it reads as the primary action on the case detail page.Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
old → newformat.