[CSM Portal] time cards: search unscoped by default instead of forcing all-project scope - #1059
Conversation
…g all-project scope The three /time-cards tabs previously defaulted filters.projectIds to every visible project when no project filter was picked, because the search returned nothing without a project scope. The backing search now supports an unscoped (global) query for internal agents, so drop the all-projects default: with no project filter we send no projectIds and the backend returns the caller's full entitlement. Picking the project filter still narrows to the chosen project(s); My time sheets and Approvals stay bounded server-side by userId/approverId. Also removes the projectIds-non-empty enabled-gate on the three tab queries so they run unscoped, and updates the now-inaccurate JSDoc.
|
Warning Review limit reached
Next review available in: 30 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 participants
Purpose
The three
/time-cardstabs (My time sheets, All, Approvals) defaultfilters.projectIdsto every project the user can see when no project filter is picked. That was a workaround: the time-card search returned nothing without a project scope, so the UI padded every request with the full ~88-project list. That forces a large scope on every call and couples the search to the project list finishing loading.The backing search now supports an unscoped (global) query for internal agents, so this PR makes the UI use it: with no project filter selected, send no
projectIdsand let the backend return the caller's full entitlement. This is an improvement to how the tabs scope their search, not a bug fix.No tracked issue link (the umbrella item lives on a private board); the backing search change is tracked separately with the team.
Goals
userId/approverId.Approach
CsmTimeCardsPage.tsx:scopeProjectIdsis now just the selected project filter (empty when none picked), instead of falling back to every visible project.baseFilterstherefore omitsprojectIdswhen nothing is selected.useTimeSheets.ts: the three tab queries (useMyTimeSheets,useApprovalQueue,useAllTimeCards) no longer gateenabledon!!filters?.projectIds?.length, so they run unscoped.searchTimeCardsalready omitsprojectIdsfrom the payload when the array is empty, so no change there.projectIdswas required.Depends on (merge/deploy gate): the unscoped path only returns data when (1) the backing search change is live on the data source the target environment uses, and (2) the calling identity holds an internal agent role. Until both hold in a given environment, unscoped tabs would come back empty there. This is why it's a separate, reviewable change rather than folded into the earlier filter work.
User stories
Release note
Time-card tabs now search across all entitled records by default instead of requiring an all-projects scope; the project filter still narrows results.
Documentation
N/A — internal CSM portal UI, no external product documentation covers this feature.
Training
N/A — not training content.
Certification
N/A — no certification exam impact.
Marketing
N/A — internal tooling, not customer-facing marketing content.
Automation tests
Unit tests
pnpm test— allcsm-timecardssuites pass;tsc -bclean;pnpm buildclean;eslintclean on the two changed files. (Pre-existing, unrelated failures on the base branch:csm-cases/CaseActionBar.test.tsxand aneslinterror incsm-operations/ChangeRequestsFilterBar.tsx— both present before this change and outside its scope.)Integration tests
Existing time-card Playwright specs are unchanged. A full live E2E run depends on the backing unscoped search being live in the target environment (see the merge/deploy gate under Approach); not re-run here.
Security checks
eslint/tscrun clean on the changed files. Authorization for the unscoped path is enforced server-side (internal-agent role check), not in the client.Samples
N/A
Related PRs
Follows the time-card filter/pagination work in #1055 (merged into
dev-app-csm-portal).Migrations (if applicable)
N/A — no data migration; frontend request-scoping change only.
Test environment
Node + pnpm; Vite build; Vitest unit tests. Verified locally against
dev-app-csm-portal.Learning
N/A