Remove the AASM dependency #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf4
commented
Dec 17, 2018
| expect(subject).to be_open | ||
| end | ||
|
|
||
| if defined?(AASM::InvalidTransition) |
bf4
commented
Dec 17, 2018
| @@ -1,3 +1,3 @@ | |||
| module CircuitBreaker | |||
| VERSION = '1.1.2' | |||
| VERSION = '1.2.0' | |||
Conflicts: lib/circuit_breaker/circuit_state.rb spec/circuit_breaker_spec.rb
bf4
commented
Dec 17, 2018
| @@ -0,0 +1,15 @@ | |||
| class CircuitBreaker::InvalidTransition < RuntimeError | |||
There was a problem hiding this comment.
normally I wouldn't inherit from a runtime error, but it appears that's what aasm does https://github.com/rubyist/aasm/blob/a4bc27cff0d7b7fa5ef61e517555e17b82285254/lib/aasm/errors.rb
module AASM
class InvalidTransition < RuntimeError; end
class UndefinedState < RuntimeError; end
endThere was a problem hiding this comment.
old code has all the extra methods on it
module AASM
class UnknownStateMachineError < RuntimeError; end
class InvalidTransition < RuntimeError
attr_reader :object, :event_name, :originating_state, :failures
def initialize(object, event_name, state_machine_name, failures = [])
@object, @event_name, @originating_state, @failures = object, event_name, object.aasm(state_machine_name).current_state, failures
super("Event '#{event_name}' cannot transition from '#{originating_state}'.#{reasoning}")
end
def reasoning
" Failed callback(s): #{failures}." unless failures.empty?
end
end
class UndefinedState < RuntimeError; end
class NoDirectAssignmentError < RuntimeError; end
end
|
Tested on Ruby 2.4 using wwtd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #14