-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 482 fix event display #350
Conversation
… formatter. #482.
@mariacha since you are the original creator I can't ask you to code review, but this is assigned to you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@unclegcb do you have time to make a few more changes here? I found two suggestions, hopefully small
entity_type: node | ||
bundle: event | ||
label: 'Calendar Description' | ||
description: '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's give this a more helpful description:
The event description in the "Add to Calendar" link. Default value is "[node:title] - from WRI: [node:url:absolute]"
(you'll have to html encode the brackets so they look right and can be copy/pasted)
|
||
// Attach the fields to the Event node. | ||
\Drupal::service('distro_helper.updates') | ||
->installConfig('field.field.node.event.field_calendar_description', 'wri_event', 'install', 'TRUE'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're still using the old-fashioned pantheon commands drush updb
then drush cim
this new field is getting deleted and re-created post-update. Can you update Distro helper to call the syncUUIDs
command right before the config gets auto-exported here? Then open a new branch and we'll test it out on this repo.
What issue(s) does this solve?
What is the new behavior?
Profile requirements:
Site-level pull requests for testing. Only merge when these PRs are approved:
Create or update any site-level pull requests following the documentation
Checked on develop (TA to do)