FLAG-1263: Data mart api client #4966
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return; | ||
| } | ||
|
|
||
| if (slugs.length === 1) { |
Check failure
Code scanning / CodeQL
Type confusion through parameter tampering Critical
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 6 days ago
To fix the problem, we need to ensure that the slugs parameter is always treated as an array of strings. We can do this by checking the type of slugs and converting it to an array if it is not already one. This will prevent type confusion attacks and ensure that the code behaves as expected.
We will modify the fetchDataByDatasetAndGeostore and postData functions to include type checks and conversions for the slugs parameter. Specifically, we will:
- Check if
slugsis an array. If not, convert it to an array containing the single value. - Proceed with the existing logic, which assumes
slugsis an array.
Suggested changeset
1
pages/api/datamart/v0/land/[...slug].js
| @@ -40,3 +40,4 @@ | ||
| // TODO: add more parameters to the query like, global, adm9, adm1, etc etc etc | ||
| const { slug: slugs, geostore_id, canopy_cover } = query; | ||
| const { slug: slugsParam, geostore_id, canopy_cover } = query; | ||
| const slugs = Array.isArray(slugsParam) ? slugsParam : [slugsParam]; | ||
|
|
||
| @@ -78,3 +79,4 @@ | ||
| // TODO: add more parameters to the query like, global, adm9, adm1, etc etc etc | ||
| const { slug: slugs, geostore_id, canopy_cover } = query; | ||
| const { slug: slugsParam, geostore_id, canopy_cover } = query; | ||
| const slugs = Array.isArray(slugsParam) ? slugsParam : [slugsParam]; | ||
|
|
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Brief description of what this PR does, and why it is needed.
Demo
If applicable: screenshots, gifs, etc.
Notes
If applicable: ancilary topics, caveats, alternative strategies that didn't work out, etc.
Testing