Skip to content

FLAG-1297 - Fix unresponsive map when panning or zooming #4960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2025
Merged

FLAG-1297 - Fix unresponsive map when panning or zooming #4960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion components/map/selectors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,9 @@ export const getMapViewport = createSelector([getMapSettings], (settings) => {
pitch,
latitude: center?.lat,
longitude: center?.lng,
transitionDuration: 500,
// The map transition needs to always be 0 otherwise the map becomes sluggish when panned or zoomed. Only set a
// different value when flying between locations and only temporarily.
transitionDuration: 0,
};
});

Expand Down
3 changes: 3 additions & 0 deletions components/ui/map/component.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,9 @@ class Map extends Component {
onResize={this.onResize}
onLoad={this.onLoad}
getCursor={getCursor}
// If the `transitionDuration` is not 0, then the map becomes sluggish when panned or zoomed. Nevertheless,
// we still want a transition when flying between locations.
transitionDuration={flying ? viewport.transitionDuration || 0 : 0}
transitionInterpolator={new FlyToInterpolator()}
transitionEasing={easeCubic}
preventStyleDiffing
Expand Down
Loading