Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy #4957

Merged
merged 5 commits into from
Mar 7, 2025
Merged

Deploy #4957

merged 5 commits into from
Mar 7, 2025

Conversation

willian-viana
Copy link
Collaborator

@willian-viana willian-viana commented Mar 7, 2025 •
edited
Loading

@willian-viana willian-viana requested a review from gtempus March 7, 2025 15:49
@willian-viana willian-viana self-assigned this Mar 7, 2025
@willian-viana willian-viana marked this pull request as ready for review March 7, 2025 15:49
gtempus
gtempus requested changes Mar 7, 2025
View reviewed changes
Copy link

@gtempus gtempus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're still on 3.6 in production. We need to remove the second 4.1 request to the RW Areas MS.

@willian-viana willian-viana mentioned this pull request Mar 7, 2025
Merged
@willian-viana
Merge pull request #4958 from wri/chore/gadm-get-areas
ecd9367 
chore(gadm): comment gadm 4.1 logic inside getAreas
@willian-viana willian-viana requested a review from gtempus March 7, 2025 18:34
gtempus
gtempus approved these changes Mar 7, 2025
View reviewed changes
Copy link

@gtempus gtempus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @willian-viana. 👍

@willian-viana willian-viana merged commit a03d706 into master Mar 7, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtempus gtempus gtempus approved these changes

Assignees

@willian-viana willian-viana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willian-viana @gtempus