Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLAG-997] GADM country list #4891

Open
wants to merge 34 commits into
base: epic/gadm
Choose a base branch
from
Open

[FLAG-997] GADM country list #4891

wants to merge 34 commits into from

Conversation

willian-viana
Copy link
Collaborator

Overview

Brief description of what this PR does, and why it is needed.

Demo

If applicable: screenshots, gifs, etc.

Notes

If applicable: ancilary topics, caveats, alternative strategies that didn't work out, etc.

Testing

  • Include any steps to verify the features this PR introduces.
  • If this fixes a bug, include bug reproduction steps.

@willian-viana willian-viana self-assigned this Nov 25, 2024
@willian-viana willian-viana force-pushed the epic/gadm branch 2 times, most recently from 4d0b54d to f6a9065 Compare November 25, 2024 14:58
@willian-viana willian-viana force-pushed the feat/GADM-country-list-FLAG-997 branch 3 times, most recently from dad9bf0 to eb3e427 Compare November 25, 2024 15:06
@willian-viana willian-viana force-pushed the feat/GADM-country-list-FLAG-997 branch from eb3e427 to 2223e1c Compare November 25, 2024 17:02
@willian-viana willian-viana marked this pull request as ready for review December 18, 2024 18:17
@willian-viana willian-viana force-pushed the feat/GADM-country-list-FLAG-997 branch from 2223e1c to 6a8efa2 Compare December 18, 2024 18:18
@willian-viana willian-viana changed the title [FLAG-997] GADM coutry list [FLAG-997] GADM country list Dec 19, 2024
willian-viana
willian-viana commented Jan 16, 2025
View reviewed changes
@willian-viana willian-viana force-pushed the feat/GADM-country-list-FLAG-997 branch from f860c72 to 2175cad Compare January 21, 2025 19:29
@willian-viana willian-viana force-pushed the feat/GADM-country-list-FLAG-997 branch from 6e81f81 to ee40c05 Compare January 23, 2025 22:01
@willian-viana willian-viana force-pushed the feat/GADM-country-list-FLAG-997 branch from ee40c05 to 0b2fdf7 Compare January 23, 2025 22:03
willian-viana and others added 21 commits April 1, 2025 16:11
@willian-viana
feat(location-service): add location tests
f3d2753
@willian-viana
feat(country-service): add tests for country service
903f555
@willian-viana
fix(gadm): fix setSubRegions actions
cfa7374
@willian-viana
chore(gadm): remove 3.6 from GADM methods name
a33a935
@willian-viana
feat(gadm): add tests for gadm utils
70d760e
@willian-viana
chore(fao): remove WHERE 1 = 1
87f566c
@willian-viana
chore(location-service): refact countryConfig to avoid providers dupl…
5d387a2 
…ication
@willian-viana
chore(country-service): improve tests adding SQL queries directly
3618a54
@willian-viana
fix(gadm): fix adm level validation
15938ba
@willian-viana
fix(gadm): add name_0 as a fallback for country name
a54e8ad
@willian-viana
fix(gadm): remove conflicted areas from country list
92f1c22
@willian-viana
fix(country-list): fix country order
38b88d5
@willian-viana
feat(gadm): remove Taiwan and Caspian Sea from the GADM country list
2d276ae
@willian-viana
feat(gadm): set new dataset versions
1474ceb
@willian-viana
chore(geostore): set gadm version to 4.1
57b42af
@willian-viana
chore(gadm): set gadm version to 4.1 inside getAreas
247f3b7
@wri7tno @willian-viana
feat(aoi-card): display outdated areas warning and modal for gadm 3.6…
6f4e126 
… areas
@willian-viana
chore(country-service): enforce long names for countries larger than …
55c3bff 
…32 chars
@willian-viana
feat(search): remove carto from geocoding serach location
3ce241e
@willian-viana
feat(search): remove interaction when user clicks on search result
917ec76 
Now, we centralize the map to display the search result, however the popup to analyze the area won't be displayed until the user click on the area
@willian-viana
chore(gadm): set gadm version to 4.1 and remove hard coded endpoint f…
2b2ce96 
…rom geostore service
@willian-viana willian-viana force-pushed the feat/GADM-country-list-FLAG-997 branch from 4884215 to f7f2565 Compare April 1, 2025 19:12
@willian-viana willian-viana temporarily deployed to gfw-staging-pr-4891 April 1, 2025 19:12 Inactive
@willian-viana
chore(cache): set maxAge to 0 to invalidate cache
5691168 
We will set 10 months right after this commit
@willian-viana willian-viana force-pushed the feat/GADM-country-list-FLAG-997 branch from f7f2565 to 5691168 Compare April 1, 2025 19:24
@willian-viana willian-viana temporarily deployed to gfw-staging-pr-4891 April 1, 2025 19:25 Inactive
@willian-viana willian-viana temporarily deployed to gfw-staging-pr-4891 April 1, 2025 19:55 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtempus gtempus gtempus approved these changes

@wri7tno wri7tno wri7tno approved these changes

Assignees

@willian-viana willian-viana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@willian-viana @gtempus @wri7tno @clementprdhomme