Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Ranked gain widget parent location #3707

Merged
merged 4 commits into from
Feb 26, 2019
Merged

Fix: Ranked gain widget parent location #3707

merged 4 commits into from
Feb 26, 2019

Conversation

01painadam
Copy link
Contributor

@01painadam 01painadam commented Feb 20, 2019 •
edited

Overview

The ranked gain widget should have access the parent locations (e.g. Acre's parent is Brazil, Brazils is Global etc)

This update the 'getLocationsObject' function to include parent information as well as teh admin level of the selected location.

screen shot 2019-02-20 at 11 53 58

screen shot 2019-02-20 at 11 54 59

@01painadam 01painadam added the bugfix Fixes for features or staging label Feb 20, 2019
@01painadam 01painadam added hotfix Urgent fixes to production bugs and removed bugfix Fixes for features or staging labels Feb 20, 2019
dfrico
dfrico approved these changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@dfrico dfrico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well at all levels. Nice! 👍

edbrett
edbrett reviewed Feb 24, 2019
View reviewed changes
Copy link
Contributor

@edbrett edbrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am getting errors with sentences not showing for certain countries. Can you review Rwanda for example? Otherwise the PR looks. good.

@01painadam
Copy link
Contributor Author

It's the '<0.1%' bug again. I've fixed it for all widgets.

@edbrett edbrett merged commit 631fc0a into develop Feb 26, 2019
@edbrett edbrett deleted the fix/ranked-gain-parent branch February 26, 2019 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edbrett edbrett edbrett left review comments

@dfrico dfrico dfrico approved these changes

@benlaken benlaken Awaiting requested review from benlaken

Assignees
No one assigned
Labels
hotfix Urgent fixes to production bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@01painadam @dfrico @edbrett