Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check for undefined state in thunk actions when hmr #3686

Merged
merged 1 commit into from
Jan 15, 2019
Merged

check for undefined state in thunk actions when hmr #3686

merged 1 commit into from
Jan 15, 2019

Conversation

edbrett
Copy link
Contributor

@edbrett edbrett commented Jan 15, 2019

Adds additional checks for getState() calls within redux thunk actions to prevent the app crashing when HMR triggers a refresh.

@edbrett edbrett requested a review from dfrico January 15, 2019 16:19
@edbrett edbrett added the develop Any PR that is ready to be merged to develop label Jan 15, 2019
dfrico
dfrico approved these changes Jan 15, 2019
View reviewed changes
Copy link
Contributor

@dfrico dfrico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Difficult to test completely, but the code seems ok, and the app works as expected.

@dfrico dfrico merged commit 303338a into develop Jan 15, 2019
@edbrett edbrett deleted the fix/hmr-undefined-state branch February 28, 2019 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfrico dfrico dfrico approved these changes

Assignees
No one assigned
Labels
develop Any PR that is ready to be merged to develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edbrett @dfrico