Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/whrc biomass widget (simple sentence) #3677

Merged
merged 25 commits into from
Feb 13, 2019
Merged

Conversation

dfrico
Copy link
Contributor

@dfrico dfrico commented Dec 19, 2018

Overview

This widget features a ranked list and information about biomass density and total biomass of a region. It has settings to change tree cover threshold, as well as a "view on map" button (above ground biomass density).

On global, it shows the top 5 countries by total biomass, and on every other region the ranked list is ordered according to the variable that is selected. The list shows the current region in the middle, and the two above and below.

The widget uses the data from the whrc-biomass endpoint.

image

@dfrico dfrico requested a review from edbrett December 19, 2018 15:45
@edbrett edbrett added the WIP Any PR that should not be merged to develop label Jan 9, 2019
@edbrett edbrett changed the title whrc biomass widget (simple sentence) Feature/whrc biomass widget (simple sentence) Jan 9, 2019
@edbrett edbrett added the staging Any PR expected to be kept on staging label Jan 9, 2019
@dfrico
Copy link
Contributor Author

dfrico commented Jan 14, 2019

Note when merging: file app/javascript/services/climate.js integrates with the same (new) file in this PR.

@benlaken
Copy link
Contributor

Looks like nothing changes with canopy setting - maybe the table that was generated was only done for a default canopy threshold. I will need to double check this.

@dfrico dfrico added develop Any PR that is ready to be merged to develop and removed WIP Any PR that should not be merged to develop labels Jan 15, 2019
@edbrett
Copy link
Contributor

edbrett commented Jan 16, 2019

Can you update this PR description etc to match the new features.

@edbrett edbrett added the WIP Any PR that should not be merged to develop label Feb 8, 2019
@benlaken benlaken self-requested a review February 11, 2019 16:43
Copy link
Contributor

@benlaken benlaken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it is working really nicely, from an intention stand-point you can go ahead and merge this when ready.

{formatNumber({ num: item.value, unit })}
{formatNumber({
num: item.value,
unit: item.unit ? item.unit : unit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not item.unit || unit ?

@dfrico dfrico force-pushed the feature/whrc-biomass branch from 409000a to 11ad8d3 Compare February 13, 2019 15:15
@edbrett edbrett removed the WIP Any PR that should not be merged to develop label Feb 13, 2019
@edbrett edbrett merged commit 2a9c9b2 into develop Feb 13, 2019
@edbrett edbrett deleted the feature/whrc-biomass branch February 13, 2019 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
develop Any PR that is ready to be merged to develop staging Any PR expected to be kept on staging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants