Feature/module maps #3671
Merged
Feature/module maps #3671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM except for links to view on map on the Explore --> topics cards. |
benlaken
approved these changes
Dec 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Currently we have a single monolith of a map that is rather over encumbered. As we will be needed the same map in the dashboards and potentially other parts of the site it would be nice if we split the map out into a simple map component and a use that to build specific layout components for other maps.
This PR addresses this by creating a maps folder with map component inside that handles to simple component. An additional map component exist for the main map.
WARNING: this PR is pretty un-reviewable due to the amount of file index changes. I recommend checking out the branch and testing the map features themselves.
Additional fixes: