Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: global disclaimer to footer of widgets #3477

Merged
merged 3 commits into from
Jun 14, 2018

Conversation

edbrett
Copy link
Contributor

@edbrett edbrett commented Jun 13, 2018

We needed a way of showing to the user that when the user selects certain datasets, they are not globally available and only account for X number of countries, now we do!

This required a fetch to the data table for the widgets to handle the dynamic checking of countries for each option, and then passing these through the props to the widget footer component.

screen shot 2018-06-13 at 16 34 08

@edbrett edbrett requested review from 01painadam and pjosh June 13, 2018 14:34
@edbrett edbrett added the staging Any PR expected to be kept on staging label Jun 13, 2018
Copy link
Contributor

@pjosh pjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well! 👍

@edbrett edbrett merged commit 7b902ec into develop Jun 14, 2018
@edbrett edbrett deleted the feature/global-data-disclaimer branch June 14, 2018 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staging Any PR expected to be kept on staging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants