Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: GA events for widget settings menu #3465

Merged
merged 1 commit into from
Jun 6, 2018
Merged

Feature: GA events for widget settings menu #3465

merged 1 commit into from
Jun 6, 2018

Conversation

edbrett
Copy link
Contributor

@edbrett edbrett commented Jun 5, 2018

Updates the GA event for the widget settings menu to now:

  • Send the widget
  • Send the selector changed
  • Send the settings value that has changed

This should allow us to analyse better how to improve the widget settings 💯

@edbrett edbrett requested a review from pjosh June 5, 2018 16:21
pjosh
pjosh approved these changes Jun 6, 2018
View reviewed changes
Copy link
Contributor

@pjosh pjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

@edbrett edbrett merged commit bd3a7e1 into develop Jun 6, 2018
@edbrett edbrett deleted the feature/new-analytics-events-for-widget-settings branch June 6, 2018 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjosh pjosh pjosh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edbrett @pjosh