Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/gee design improvements #3375

Merged
merged 16 commits into from
Apr 25, 2018

Conversation

pjosh
Copy link
Contributor

@pjosh pjosh commented Apr 23, 2018

Overview

  • Some style improvements
  • Empty state when we don't have enough thumbnails
  • Responsive behaviour

@pjosh pjosh requested a review from edbrett April 23, 2018 12:01
Copy link
Contributor

@edbrett edbrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work buddy. Some updates needed for the access in mobile which you are aware off. 🏇 🙀

@@ -17,7 +17,9 @@
}

&.--active {
background-color: $border;
background-color: $green-gfw;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will also change the country pages button.

{tiles.length < 2 && (
<NoContent
className="c-recent-imagery-settings__empty-thumbnails"
message="We haven't found more images for this selection"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to say "We can't find additional images for the selection"

@edbrett edbrett merged commit 854a1aa into feature/GEE-recent-imagery Apr 25, 2018
@edbrett edbrett deleted the feature/GEE-design-improvements branch April 25, 2018 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants