Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move all components to global folder #3361

Merged
merged 3 commits into from
Apr 17, 2018
Merged

Move all components to global folder #3361

merged 3 commits into from
Apr 17, 2018

Conversation

edbrett
Copy link
Contributor

@edbrett edbrett commented Apr 13, 2018

Simple PR to move components that should be global to the components folder in order to simplify pages and reusability:

  • Widgets
  • Widget components
  • Charts

@edbrett edbrett requested a review from pjosh April 13, 2018 16:45
@pjosh
Copy link
Contributor

pjosh commented Apr 17, 2018

I've found this error:
captura de pantalla 2018-04-17 a las 8 21 20

@edbrett
Copy link
Contributor Author

edbrett commented Apr 17, 2018

I think you will need to restart your server

pjosh
pjosh approved these changes Apr 17, 2018
View reviewed changes
Copy link
Contributor

@pjosh pjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing job! 🎖 👏

@edbrett edbrett merged commit 540bfad into develop Apr 17, 2018
@edbrett edbrett deleted the feature/abstract-components branch April 17, 2018 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjosh pjosh pjosh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edbrett @pjosh