Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/404s #3349

Merged
merged 2 commits into from
Mar 26, 2018
Merged

Fix/404s #3349

merged 2 commits into from
Mar 26, 2018

Conversation

edbrett
Copy link
Contributor

@edbrett edbrett commented Mar 26, 2018

Our feedback to users when visiting incorrect endpoints was very out of date:

  • 500, 404, 422 all updated to handle new header and styles
  • Country pages hides widgets and data when viewing an incorrect location
  • Redirect from country react app to 404 when a bad url is requested.

@edbrett edbrett requested a review from pjosh March 26, 2018 10:28
pjosh
pjosh approved these changes Mar 26, 2018
View reviewed changes
Copy link
Contributor

@pjosh pjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!

app/views/layouts/about.html.erb
<%= yield %>
<div id="footerGfw"></div>
</body>
</html>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tidy up! 👏

public/422.html
</body>
</html>

<script type="text/javascript" src="http://code.jquery.com/jquery-1.11.0.min.js"></script>
<script type="text/javascript" src="http://cdn.jsdelivr.net/jquery.slick/1.3.15/slick.min.js"></script>
<script id="loader-gfw" type="text/javascript" src="https://cdn.rawgit.com/simbiotica/gfw_assets/bce5294264c2ecc25a9fcf46ed356116564f5c2d/src/header-loader.js" data-current=".shape-house"></script>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow!

@pjosh pjosh merged commit c714151 into develop Mar 26, 2018
@pjosh pjosh deleted the fix/404s branch March 26, 2018 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjosh pjosh pjosh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@edbrett @pjosh