Improve DA RANDOMCV capability#967
Merged
jamiebresch merged 1 commit intowrf-model:developfrom Aug 23, 2019
Merged
Conversation
modified: Registry/registry.var modified: var/README.namelist modified: var/da/da_define_structures/da_initialize_cv.inc modified: var/da/da_main/da_solve.inc modified: var/da/da_main/da_wrfvar_top.f90 modified: var/da/da_tools/da_set_randomcv.inc
liujake
approved these changes
Aug 4, 2019
Contributor
|
@jamiebresch this PR was approved. Can you merge it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: enhancement
KEYWORDS: WRFDA, RANDOMCV
SOURCE: Jamie Bresch (NCAR/MMM), Tom Auligne (previously NCAR, initiated the change in 2010)
DESCRIPTION OF CHANGES:
Simplify and cleanup the analysis_type="RANDOMCV" capability.
(1) Remove unnecessary and redundant code for anal_type_randomcv.
Non-relevant files and log messages are not written out.
(2) Add a new namelist n_randomcv (default=1) to allow the generation of multiple perturbed output in one run.
For example, wrfvar_output_randomcv.e001, wrfvar_output_randomcv.e002, etc.
The changes have no impact on non-RANDOMCV applications.
LIST OF MODIFIED FILES:
M Registry/registry.var
M var/README.namelist
M var/da/da_define_structures/da_initialize_cv.inc
M var/da/da_main/da_solve.inc
M var/da/da_main/da_wrfvar_top.f90
M var/da/da_tools/da_set_randomcv.inc
TESTS CONDUCTED:
With default n_randomcv=1, the new code generates identical wrfvar_output as the origonal code.
RELEASE NOTE: WRFDA analysis_type="RANDOMCV" is improved. To get multiple perturbed output in one WRFDA run, set new namelist n_randomcv to the desired number.