Skip to content

A new cloud detection scheme based on Particle Filter#887

Merged
liujake merged 7 commits intowrf-model:developfrom
xdmjolly:pf-cloud-detect
May 3, 2019
Merged

A new cloud detection scheme based on Particle Filter#887
liujake merged 7 commits intowrf-model:developfrom
xdmjolly:pf-cloud-detect

Conversation

@xdmjolly
Copy link
Contributor

@xdmjolly xdmjolly commented Apr 22, 2019

TYPE: new feature

KEYWORDS: WRFDA, Infrared Radiance Data Assimilation, Cloud detection

SOURCE: Dongmei Xu (NUIST/NCAR), Thomas Auligné(NCAR, now at JCSDA)

DESCRIPTION OF CHANGES:

  1. Add a new channel-based cloud detection scheme based on the Particle Filter method for Infrared sensors such as AIRS, IASI, GOES-Imager, and AHI.

  2. Same as two other existing schemes (MMR and ECMWF) in WRFDA, this cloud-detection scheme can retain high-peaking channels not affected by cloud even though the pixel scene is covered by cloud. This scheme is computationally more efficient than MMR scheme.

  3. Integer namelist parameter 'use_clddet' determines which scheme to use (=0,1,2,3 for no cloud detection, MMR, particle filter, and ECMWF scheme). The default is set to 2 for particle filter.

LIST OF MODIFIED FILES:
M Registry/registry.var
M var/build/depend.txt
A var/da/da_radiance/da_cloud_detect.inc
D var/da/da_radiance/da_cloud_detect_airs.inc
D var/da/da_radiance/da_cloud_detect_iasi.inc
M var/da/da_radiance/da_crtm.f90
M var/da/da_radiance/da_get_innov_vector_crtm.inc
M var/da/da_radiance/da_qc_ahi.inc
M var/da/da_radiance/da_qc_airs.inc
M var/da/da_radiance/da_qc_goesimg.inc
M var/da/da_radiance/da_qc_iasi.inc
M var/da/da_radiance/da_radiance1.f90
M var/da/da_radiance/da_rttov.f90

TESTS CONDUCTED: WRFDA regression tests ran successfully with gnu/ifort+mpt on Cheyenne.

RELEASE NOTE: A new channel-based cloud detection scheme for Infrared sensors is added based on the Particle Filter method.
Xu D., T. Auligné, G. Descombes, and C. Snyder, 2016: A method for retrieving clouds with satellite infrared radiances using the particle filter. Geosci. Model Dev., 9, 3919–3932

@xdmjolly xdmjolly requested review from a team as code owners April 22, 2019 22:44
@davegill
Copy link
Contributor

@xdmjolly
Dongmei,
Please change the base of this PR to be develop (not master).

@xdmjolly xdmjolly changed the base branch from master to develop April 22, 2019 22:53
@davegill
Copy link
Contributor

@xdmjolly
Dongmei,
There seem to be a number of unintended modifications. For example, you list changing 14 files, but github says youp PR is actually changing 32 files.

@davegill
Copy link
Contributor

@xdmjolly
Dongmei,
Great, it looks like the change in the base branch (to develop) cleaned up most of the file discrepancies!
Scan through the files and then your commit message to make the modified file count to be consistent (13 vs 14 now).

@liujake
Copy link
Contributor

liujake commented Apr 22, 2019

Will review this at later time.

@liujake
Copy link
Contributor

liujake commented Apr 22, 2019

'Makefile' is an auto-genetated file during compilation, should NOT be added.

@xdmjolly
Copy link
Contributor Author

xdmjolly commented Apr 23, 2019

The inconsistency between 13 vs 14 is caused by the var/da/da_radiance/da_cloud_detect_iasi.inc,
which I renamed to be a new one as da_cloud_detect.inc. The github considered this behavior as one change.
A var/da/da_radiance/da_cloud_detect.inc
D var/da/da_radiance/da_cloud_detect_iasi.inc

@davegill
Copy link
Contributor

@xdmjolly @liujake @jjguerrette

The inconsistency between 13 vs 14 is caused by the var/da/da_radiance/da_cloud_detect_iasi.inc,
which I renamed to be a new one as da_cloud_detect.inc. The github considered this behavior as one change.

Dongmei,
Thanks for clearing up that inconsistency for me.

Jake and JJ,
This PR does not touch any of the code outside of the WRF DA responsibility. I am unfamiliar with your process for accepting new DA code. It might be helpful to have some documentation provided for users. In the commit message for example, references for the technique, instructions on how to activate this option, what the scheme is for, when to use it, assumptions that the technique makes, comparison with other methods, etc. Outside the scope of the PR, do you typically provide README files for users? Should any part of the TechNote or Users_Guide be updated to maintain currency?

@liujake
Copy link
Contributor

liujake commented Apr 29, 2019

@xdmjolly Now you have three logical namelist variables use_clddet_mmr, use_clddet_pf, and use_clddet_ecmwf for three different cloud detection schemes for 4 different sensors (airs, iasi, goes-imager, ahi). I guess these three schemes will NOT be activated/used simultaneously. So I think it is better to define an integer namelist parameter 'clddet_scheme=0,1,2,3' for no-detection, mmr, pf, and ecmwf. And I do not see ecmwf cloud-detection scheme even though you have a namelist variable for it. You may make a separate PR for ecmwf scheme. Better also add published references in your PR for MMR scheme.

@liujake
Copy link
Contributor

liujake commented Apr 29, 2019

Do mmr and pf work with both CRTM and RTTOV, or just CRTM?

@xdmjolly
Copy link
Contributor Author

mmr and pf work with both CRTM and RTTOV.
A new integer flag named as use_clddet=0,1,2,3 is now used for no-detection, mmr, pf, and ecmwf.

liujake added 2 commits May 2, 2019 22:52
make particle filter the default scheme.
align if .. end if
@liujake liujake merged commit acd2aac into wrf-model:develop May 3, 2019
@xdmjolly xdmjolly deleted the pf-cloud-detect branch May 6, 2019 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants