SH2O had two appearances in call to ssttep routine

[davegill]

TYPE: bug fix

KEYWORDS: Noah LSM sh2o unified MPAS

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
A single variable was used as two calling arguments in a subroutine. Inside the subroutine, the
separate names were pointing to the same memory and were treated differently.

Solution:
Since the two instances of the array were treated as IN and OUT, a copy of the array was made and
passed in as separately named input field. There were two locations to fix.

LIST OF MODIFIED FILES:
M phys/module_sf_noahlsm.F

TESTS CONDUCTED:

1. Comparing the results before vs after show no bit-for-bit differences (what we wanted).

../../external/io_netcdf/diffwrf INIT_develop/wrfout_d01_2000-01-24_12:00:00 INIT_FIX_dev/wrfout_d01_2000-01-24_12:00:00 
 Just plot  F
Diffing INIT_develop/wrfout_d01_2000-01-24_12:00:00 INIT_FIX_dev/wrfout_d01_2000-01-24_12:00:00
 Next Time 2000-01-24_12:00:00
     Field   Ndifs    Dims       RMS (1)            RMS (2)     DIGITS    RMSE     pntwise max
 Next Time 2000-01-24_12:03:00
     Field   Ndifs    Dims       RMS (1)            RMS (2)     DIGITS    RMSE     pntwise max
 Next Time 2000-01-24_12:06:00
     Field   Ndifs    Dims       RMS (1)            RMS (2)     DIGITS    RMSE     pntwise max
 Next Time 2000-01-24_12:09:00
     Field   Ndifs    Dims       RMS (1)            RMS (2)     DIGITS    RMSE     pntwise max
 Next Time 2000-01-24_12:12:00
     Field   Ndifs    Dims       RMS (1)            RMS (2)     DIGITS    RMSE     pntwise max

2. When the code was instrumented, the only differences were diagnostic only. No differences in any other WRF output fields. See Checking intent (inout) vs (out) for shared version of WRF-MPAS Noah LSM davegill/WRF#5

[weiwangncar]

I'm ok with the change.

[davegill]

@mgduda
Michael,
This is an email so that you can easily find this Noah LSM change.
The purpose is to see if the intent(out) -> intent(inout) mods can be removed.