Ntiedtke wrf mpas unify updates - addition of dx2d variable to clean up module#810
Merged
kkeene44 merged 2 commits intowrf-model:developfrom Mar 13, 2019
Merged
Conversation
weiwangncar
reviewed
Mar 13, 2019
Collaborator
|
I'm good with this PR now. |
Collaborator
Author
|
@weiwangncar |
weiwangncar
approved these changes
Mar 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: no impact
KEYWORDS: ntiedtke, wrf, mpas cu_physics, dx2d
SOURCE: internal
DESCRIPTION OF CHANGES: Toward an effort to use fewer if defined(mpas) (or wrfmodel) statements in the code, a dx2d variable was added to be used until WRF creates a 2d array for dx.
LIST OF MODIFIED FILES:
M phys/module_cu_ntiedtke.F
TESTS CONDUCTED: verified that WRF builds okay and that bit-for-bit results are given before/after mods.