update module_cu_ntiedtke file to identically match MPAS version#801
Merged
kkeene44 merged 1 commit intowrf-model:developfrom Mar 8, 2019
Merged
Conversation
Collaborator
|
@kkeene44 Perhaps you can add in the commit message that this particular PR defines t13 in the code rather using the Prandtl number since the Prandtl number is different in WRF and MPAS. |
Collaborator
Author
|
@weiwangncar |
weiwangncar
approved these changes
Mar 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: no impact
KEYWORDS: wrf, mpas, unification, ntiedtke, cumulus
SOURCE: internal
DESCRIPTION OF CHANGES: For the purpose of WRF/MPAS physics unification, we want the 2 models to have identical versions of each physics routine. After some mods were made to the MPAS version, this version then was behind. This particular PR defines t13 in the code rather using the Prandtl number since the Prandtl number is different in WRF and MPAS.
LIST OF MODIFIED FILES:
M phys/module_cu_ntiedtke.F
TESTS CONDUCTED: Verified that it compiles and runs fine. There were no diffs in output before/after modifications.