Skip to content

Remove hard-coded max number of tasks for obs nudging #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smileMchen merged 3 commits into from
Dec 11, 2018
Merged

Remove hard-coded max number of tasks for obs nudging #698

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
46cfa7b
Bug fix for hard coded number of processors
smileMchen Nov 16, 2018
42725b8
Update module_dm.F
smileMchen Nov 16, 2018
4758a98
Put deallocate of IDISPLACEMENT and ICOUNT inside of same ifdef where…
smileMchen Nov 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions external/RSL_LITE/module_dm.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2213,8 +2213,8 @@ SUBROUTINE get_full_obs_vector( nsta, nerrf, niobf, &
INTEGER N_BUFFER(NIOBF)
REAL FULL_BUFFER(NIOBF)
INTEGER IFULL_BUFFER(NIOBF)
INTEGER IDISPLACEMENT(1024) ! HARD CODED MAX NUMBER OF PROCESSORS
INTEGER ICOUNT(1024) ! HARD CODED MAX NUMBER OF PROCESSORS
INTEGER, ALLOCATABLE , DIMENSION(:) :: IDISPLACEMENT
INTEGER, ALLOCATABLE , DIMENSION(:) :: ICOUNT

INTEGER :: MPI_COMM_COMP ! MPI group communicator
INTEGER :: NPROCS ! Number of processors
Expand All @@ -2225,6 +2225,8 @@ SUBROUTINE get_full_obs_vector( nsta, nerrf, niobf, &

! Get rank of monitor processor and broadcast to others.
CALL MPI_COMM_SIZE( MPI_COMM_COMP, NPROCS, IERR )
ALLOCATE (IDISPLACEMENT(NPROCS))
ALLOCATE (ICOUNT(NPROCS))

! DO THE U FIELD
NLOCAL_DOT = 0
Expand Down Expand Up @@ -2369,6 +2371,8 @@ SUBROUTINE get_full_obs_vector( nsta, nerrf, niobf, &
ERRF(10,IFULL_BUFFER(N)) = FULL_BUFFER(N)
END DO

DEALLOCATE (IDISPLACEMENT)
DEALLOCATE (ICOUNT)
#endif
END SUBROUTINE get_full_obs_vector

Expand Down