Bug fix in optical_prep_gocart#667
Merged
davegill merged 2 commits intowrf-model:release-v4.0.2from Oct 24, 2018
saneku:optical_prep_gocart_0.1_instead_0.46
Merged
Bug fix in optical_prep_gocart#667davegill merged 2 commits intowrf-model:release-v4.0.2from saneku:optical_prep_gocart_0.1_instead_0.46
davegill merged 2 commits intowrf-model:release-v4.0.2from
saneku:optical_prep_gocart_0.1_instead_0.46
Conversation
Contributor
|
@saneku |
Contributor
Author
|
Done! |
davegill
reviewed
Oct 16, 2018
davegill
reviewed
Oct 16, 2018
davegill
reviewed
Oct 16, 2018
Contributor
|
@saneku @ravanah @kayeekayee |
davegill
reviewed
Oct 17, 2018
Contributor
davegill
left a comment
davegill
left a comment
There was a problem hiding this comment.
This is a clean set of modifications. I am good with this PR.
@ravanah and @kayeekayee
Please provide a review
weiwangncar
pushed a commit
that referenced
this pull request
Oct 10, 2024
) TYPE: bug fix KEYWORDS: WRF-Chem, GOCART, optical properties, dust, sea salt, AOD SOURCE: KAUST DESCRIPTION OF CHANGES: Problem: It was found that WRF-Chem with GOCART aerosol scheme disregards the radiative effect of the largest dust and sea salt particles (5th and 4th bins). Solution: Mass redistribution between GOCART dust/sea salt and MOZAIC bins now accounts for the 5th dust and 4th sea salt bins. The number of MOZAIC bins was changed from 8 to 9 and MOZAIC max size range was increased from 10 to 20 um. This PR is an addition to #667 and #677 PR. LIST OF MODIFIED FILES: M chem/module_optical_averaging.F M chem/optical_driver.F TESTS CONDUCTED: - 7-day WRF-Chem run over the Middle East with the GOCART aerosol scheme was conducted without the changes and with changes. As expected, AOD increased by 3% on average. Over dust source regions the AOD increase is more pronounced - 5% on average. See PR itself for details. - The Jenkins tests are all passing. RELEASE NOTE: Bug fix in the calculation of optical properties. Mass redistribution between GOCART dust/sea salt and MOZAIC bins was corrected. It slightly increased (by 3-5%) the aerosol optical depth (AOD).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: optical_prep_gocart, volume-averaged refractive index, WRF-Chem
SOURCE: Alexander Ukhov, KAUST
DESCRIPTION OF CHANGES:
Problem: It was found that the dust particles having radii less than 0.46 microns are not accounted in the calculation of volume-averaged refractive index needed by Mie calculations. Since the finer particles have a bigger influence on AOD in comparison to the coarser particles (per unit of mass), it eventually led to the underestimation of the AOD.
Solution: 0.46 was replaced by 0.1, where the value 0.1 corresponds to the beginning of the first GOCART bin (radii: 0.1-1.0 μm).
Left column (1-5) - GOCART dust bins.
other columns are 8 MOZAIC size bins.
dustfrc_goc8bin BEFORE CORRECTION:
dustfrc_goc8bin AFTER CORRECTION:
LIST OF MODIFIED FILES:
M chem/module_optical_averaging.F
M phys/module_data_gocart_dust.F
TESTS CONDUCTED:
Test case was run. The obtained result is expected: the AOD level has increased.