bugfix: fix potential divide by zero in stomatal resistance diagnostic#646
Merged
davegill merged 1 commit intowrf-model:release-v4.0.1from Oct 2, 2018
Merged
Conversation
KEYWORDS: Noah-MP SOURCE: Michael Barlage (NCAR) DESCRIPTION OF CHANGES: Bug fix introduced in wrf-model#399 where divide by zero can occur if LAI is zero. Added check in IF statement. This calculation is only for diagnostics so shouldn't change answers, except to prevent model crash. LIST OF MODIFIED FILES: M phys/module_sf_noahmpdrv.F TESTS CONDUCTED: Summer and winter 24-hr case
Collaborator
|
Looks OK. Prevents divide by zero. |
Collaborator
|
I'm ok with this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: Noah-MP
SOURCE: Michael Barlage (NCAR)
DESCRIPTION OF CHANGES:
Bug fix introduced in #399 where divide by zero can occur if LAI is zero. Added check in IF statement. This calculation is only for diagnostics so shouldn't change answers, except to prevent model crash.
Mods to release-v4.0.1, not develop. Replaces PR #633
LIST OF MODIFIED FILES:
M phys/module_sf_noahmpdrv.F
TESTS CONDUCTED:
Summer and winter 24-hr case