Skip to content

Fixed qc, qr, qi, qs, qg updates to WRF moist variables#625

Merged
jjguerrette merged 1 commit intowrf-model:masterfrom
jjguerrette:bugfix/cloud_cv_option_update
Sep 13, 2018
Merged

Fixed qc, qr, qi, qs, qg updates to WRF moist variables#625
jjguerrette merged 1 commit intowrf-model:masterfrom
jjguerrette:bugfix/cloud_cv_option_update

Conversation

@jjguerrette
Copy link
Contributor

@jjguerrette jjguerrette commented Sep 12, 2018

TYPE: bug fix

KEYWORDS: moist, analysis update

SOURCE: Internal (JJG)

DESCRIPTION OF CHANGES:
xatowrf now requires cloud_cv_options that match packaging defined in registry.var
for xa%qrn, xa%qcw, xa%qci, xa%qsn, and xa%qgr.

This bugfix is connected to PR #283 from 11 AUG 2017 (c7405bb#diff-fe8b020143d32583d82b945e2bd66f50)

The array bounds error this avoids occurs when mp_physics ~= [0, 98] and cloud_cv_options==0.

LIST OF MODIFIED FILES:
M var/da/da_transfer_model/da_transfer_xatowrf.inc

TESTS CONDUCTED:
The following error at the end of rsl.error.0000 is avoided with this fix when "debug" build is used for WRFDA:

forrtl: severe (408): fort: (2): Subscript #1 of the array QCW has value 2 which is greater than the upper bound of 1

Image PC Routine Line Source da_wrfvar.exe 00000000060CF996 Unknown Unknown Unknown da_wrfvar.exe 00000000017EDB3B da_transfer_model 2224 da_transfer_model.f da_wrfvar.exe 00000000018A4263 da_transfer_model 3399 da_transfer_model.f da_wrfvar.exe 00000000004C5D92 da_wrfvar_top_mp_ 3675 da_wrfvar_top.f da_wrfvar.exe 00000000004B0699 da_wrfvar_top_mp_ 2779 da_wrfvar_top.f da_wrfvar.exe 00000000004B0559 da_wrfvar_top_mp_ 2749 da_wrfvar_top.f da_wrfvar.exe 0000000000459863 MAIN__ 34 da_wrfvar_main.f da_wrfvar.exe 0000000000405C1E Unknown Unknown Unknown libc-2.19.so 00002AAAAB7E5B25 __libc_start_main Unknown Unknown da_wrfvar.exe 0000000000405B29 Unknown Unknown Unknown

The WRFDA Regression test was not run. The changes are minor and fix the known bug.

by requiring cloud_cv_options that match packaging defined in registry.var
for xa%qrn, xa%qcw, xa%qci, xa%qsn, and xa%qgr

This bugfix is connected to PR wrf-model#283 from  11 AUG 2017.

The array bounds error this avoids occurs when mp_physics ~= [0, 98] and cloud_cv_options==0.

With "debug" build of WRFDA and without fix, the end of rsl.error.0000:

forrtl: severe (408): fort: (2): Subscript wrf-model#1 of the array QCW has value 2 which is greater than the upper bound of 1

Image              PC                Routine            Line        Source
da_wrfvar.exe      00000000060CF996  Unknown               Unknown  Unknown
da_wrfvar.exe      00000000017EDB3B  da_transfer_model        2224  da_transfer_model.f
da_wrfvar.exe      00000000018A4263  da_transfer_model        3399  da_transfer_model.f
da_wrfvar.exe      00000000004C5D92  da_wrfvar_top_mp_        3675  da_wrfvar_top.f
da_wrfvar.exe      00000000004B0699  da_wrfvar_top_mp_        2779  da_wrfvar_top.f
da_wrfvar.exe      00000000004B0559  da_wrfvar_top_mp_        2749  da_wrfvar_top.f
da_wrfvar.exe      0000000000459863  MAIN__                     34  da_wrfvar_main.f
da_wrfvar.exe      0000000000405C1E  Unknown               Unknown  Unknown
libc-2.19.so       00002AAAAB7E5B25  __libc_start_main     Unknown  Unknown
da_wrfvar.exe      0000000000405B29  Unknown               Unknown  Unknown

 Changes to be committed:
	modified:   var/da/da_transfer_model/da_transfer_xatowrf.inc
Copy link
Contributor

@liujake liujake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@jjguerrette jjguerrette merged commit 4cf7d62 into wrf-model:master Sep 13, 2018
@jjguerrette jjguerrette deleted the bugfix/cloud_cv_option_update branch September 14, 2018 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants