Upgrade WRFDA RTTOV interface to v12.1#624
Merged
jjguerrette merged 3 commits intowrf-model:masterfrom Sep 13, 2018
Merged
Conversation
- code has been compiled with RTTOV12.1 - preliminary 3D-Var test w/ WRFDA arctic tutorial case + minimization appears successful + results differ from RTTOV11.3 due to RTTOV updates + quantitative analysis of results has not been performed Changes to be committed: modified: compile modified: var/da/da_radiance/da_get_innov_vector_rttov.inc modified: var/da/da_radiance/da_radiance.f90 modified: var/da/da_radiance/da_rttov.f90 modified: var/da/da_radiance/da_rttov_ad.inc modified: var/da/da_radiance/da_rttov_direct.inc modified: var/da/da_radiance/da_rttov_init.inc modified: var/da/da_radiance/da_rttov_k.inc modified: var/da/da_radiance/da_rttov_tl.inc modified: var/da/da_radiance/module_radiance.f90
Changes to be committed: modified: var/da/da_radiance/da_get_innov_vector_rttov.inc modified: var/da/da_radiance/da_rttov_init.inc modified: var/da/da_radiance/module_radiance.f90
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: enhancement
KEYWORDS: RTTOV, radiance, DA, RTM
SOURCE: internal
DESCRIPTION OF CHANGES: One or more paragraphs describing problem, solution, and required changes.
The RTTOV source code was updated for new emissivity formulations and new coefficient files. The updated version of RTTOV (12.1) deprecates NETCDF formatted emissivity atlas files in favor of only using HDF5 format. Additionally, the interface to those emissivity atlas files has changed and several internal derived type names have changed.
This PR updates WRFDA to handle those changes to RTTOV. Compiling WRFDA for use with RTTOV will now require an HDF5 library.
LIST OF MODIFIED FILES:
M compile
M var/da/da_radiance/da_get_innov_vector_rttov.inc
M var/da/da_radiance/da_radiance.f90
M var/da/da_radiance/da_rttov.f90
M var/da/da_radiance/da_rttov_ad.inc
M var/da/da_radiance/da_rttov_direct.inc
M var/da/da_radiance/da_rttov_init.inc
M var/da/da_radiance/da_rttov_k.inc
M var/da/da_radiance/da_rttov_tl.inc
M var/da/da_radiance/module_radiance.f90
TESTS CONDUCTED:
The WRFDA regression test was conducted for both GNU and INTEL compilers. All secnarios give "match" result except for the four tests discussed below.
This output is incorrect since THM is available in both wrfvar_output files. The problem appears to be caused by a "string" label in the nc4 wrfvar_output files for attributes of THM, C1F, C2F, C3F, C4F, C1H, C2H, C3H, and C4H that is not present for any other variables or in the non-nc4 version of these files. This is shown below in the THM lines from 'ncdump -h'.