Skip to content

Remove the "_new" string from the arch dir file names, and the associated file references#508

Merged
davegill merged 5 commits intowrf-model:masterfrom
davegill:no_new
May 10, 2018
Merged

Remove the "_new" string from the arch dir file names, and the associated file references#508
davegill merged 5 commits intowrf-model:masterfrom
davegill:no_new

Conversation

@davegill
Copy link
Contributor

@davegill davegill commented May 10, 2018

TYPE: no impact

KEYWORDS: _new, arch

SOURCE: internal, reported by Michael Duda (NCAR)

DESCRIPTION OF CHANGES:

  1. Four files in the arch dir have the "_new" string removed from their file names.
    a. arch/Config.pl
    b. arch/configure.defaults
    c. arch/postamble
    d. arch/preamble
  2. The files that use these modified file names, need to be updated to remove the reference to the _new part of the file name.
    a. arch/Config.pl
    b. compile
    c. configure

LIST OF MODIFIED FILES: list of changed files (use git diff --name-status master to get formatted list)
M arch/Config.pl
M arch/configure.defaults
M arch/postamble
M arch/preamble
M compile
M configure

TESTS CONDUCTED:

  1. Code successfully builds.

davegill added 4 commits May 9, 2018 21:42
…rs ago

TYPE: no impact

KEYWORDS: _new, arch

SOURCE: internal, pointed out by Michael Duda (NCAR)

DESCRIPTION OF CHANGES:
1. Rename the four files in the arch directory that had the _new string.

LIST OF MODIFIED FILES: list of changed files (use `git diff --name-status master` to get formatted list)

TESTS CONDUCTED: Explicitly state if a WTF and or other tests were run, or are pending. For more complicated changes please be explicit!
@davegill davegill requested a review from mgduda May 10, 2018 04:10
@davegill
Copy link
Contributor Author

@mgduda
Michael,
Thanks for the reminder.

@jamiebresch
Copy link
Contributor

configure_new.defaults is mentioned in preamble_new.

@davegill
Copy link
Contributor Author

@jamiebresch
Jamie,
Thanks!
I'll do a find/grep command to search for use of any of the modified files

@jamiebresch
Copy link
Contributor

:shipit:

Copy link
Collaborator

@mgduda mgduda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@davegill davegill merged commit 7b8344b into wrf-model:master May 10, 2018
@davegill davegill deleted the no_new branch May 10, 2018 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants