TL/AD code sync with WRF changes#474
Merged
liujake merged 7 commits intowrf-model:masterfrom May 2, 2018
Merged
Conversation
…anges Changes committed: modified: Registry/Registry.EM_COMMON.tladj modified: Registry/Registry.tladj modified: wrftladj/module_first_rk_step_part1_ad.F modified: wrftladj/solve_em_ad.F
modified: Registry/Registry.EM_COMMON.tladj modified: wrftladj/solve_em_ad.F
Contributor
Author
|
can someone approve this? |
modified: Makefile
modified: var/da/da_main/da_update_firstguess.inc
Contributor
Author
|
@davegill @weiwangncar @dudhia |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: WRFPlus sync
KEYWORDS: TL/AD code, Sync
SOURCE: Internal
DESCRIPTION OF CHANGES:
Recent changes in WRF lead to WRFPlus compilation failure. This update fixed compilation failure.
This commit allows WRFPlus/WRFDA-3DVAR/4DVAR to work properly with namelist setting
&dynamics
hybrid_opt=0,
etac=0.0,
use_theta_m=0,
/
, which means MOIST_THETA-T0=T for WRFDA's input and output files and hybrid vertical coordinate is reduced to the original mass coordinate with the values of 8 1D variables in the file:
C1F = 1
C2F = 0
C3F = znw
C4F = 0
C1H = 1
C2H = 0
C3H = znu
C4H = 0
LIST OF MODIFIED FILES:
M Makefile
M Registry/Registry.EM_COMMON.tladj
M Registry/Registry.tladj
M var/da/da_main/da_update_firstguess.inc
M wrftladj/module_first_rk_step_part1_ad.F
M wrftladj/solve_em_ad.F
TESTS CONDUCTED:
[x] No test for WTF model tests (not needed)
[x] Passed 3dvar, wrfplus, and 4dvar in WTF using new wrf file (with hybrid_opt=0, etac=0.0, use_theta_m=0) with gnu compiler
[x] Run through all WRFDA regression tests (including two DA/forecast cycling cases) with gnu and ifort (with modified wrfinput/fg input files).