Conversation
|
|
@joeolson42 Will do a separate PR for depend.common. |
|
Not sure the depend.common change is needed anyway. I think that is only for dependencies outside the phys directory. GFL is already listed in the phys/Makefile. |
The GFL PR that went in did not properly set up the make dependencies. The |
|
OK, I see depend.common may have some outdated gf files listed. |
|
islas
left a comment
There was a problem hiding this comment.
I think the PR description TYPE section should also be updated to only select one thing.
remove duplicate change.
@joeolson42 @islas I have made the change. |
|
Updated PR description |
The purpose for this PR is to update the refactored MYNN surface layer scheme, which has now been more fully debugged and has been tested in both WRF and MPAS.
TYPE: enhancement
KEYWORDS: MYNN-SFC version 6.0.0 refactored HRRR
SOURCE: Joseph B. Olson
DESCRIPTION OF CHANGES:
The Main Problem:
This scheme was refactored starting from the CCPP version, which has a few distinctions from WRF/MPAS that required further work to fully integrate into both WRF and MPAS.
Solutions:
LIST OF MODIFIED FILES: list of changed files (use
git diff --name-status masterto get formatted list)M phys/MYNN-SFC
M phys/module_surface_driver.F
TESTS CONDUCTED: